Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy Dev] Add a script to upload a partner from partners.json to firestore. #594

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zozoens31
Copy link
Contributor

@zozoens31 zozoens31 commented Jan 8, 2021

This change is Reviewable

Copy link
Contributor

@emilieguth emilieguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1.
Reviewable status: Unresolved discussions (server/Dockerfile:r1 line 16)


server/Dockerfile, line 16 at r1 (raw file):

  node_modules/.bin/firebase emulators:exec --only firestore 'echo "Emulator preloaded"'

COPY .eslintrc.json .eslintignore server/.firebaserc server/clean_dependencies.sh server/entrypoint.sh server/firebase.json server/firestore.indexes.json server/firestore.rules server/tsconfig.json server/upload_partner.ts src/store/partners.json ./

upload_partnerS.ts


server/package.json, line 14 at r1 (raw file):

    "predeploy": "npm run apidoc",
    "test": "firebase emulators:exec --only firestore 'mocha test/*.ts --require ts-node/register'",
    "upload": "GOOGLE_APPLICATION_CREDENTIALS='./credentials/serviceAccountKey.json' ts-node upload_partner.ts"

upload_partnerS.ts


server/tsconfig.json, line 17 at r1 (raw file):

  "include": [
    "src",
    "upload_parters.ts"

upload_partNers.ts

Copy link
Contributor Author

@zozoens31 zozoens31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: Unresolved discussions (server/tsconfig.json:r1 line 17)


server/Dockerfile, line 16 at r1 (raw file):

Previously, emilieguth (Émilie Guth) wrote…

upload_partnerS.ts

But it uploads just the one...

Base automatically changed from master to main February 8, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants